This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Moves ledger notification into separate files #11882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves brave#11876 Auditors: Test Plan:
NejcZdovc
force-pushed
the
refactor/#11876-notifications
branch
from
8582e3e
to
8174ced
Compare
|
travis-ci seems to be having an issue- all the tests failed. I restarted, let's see how those look before merge |
|
@bsclifton tests are failing on master as well https://travis-ci.org/brave/browser-laptop/builds/299807390 |
bsclifton
added a commit
that referenced
this pull request
Nov 10, 2017
Moves ledger notification into separate files
bsclifton
added a commit
that referenced
this pull request
Nov 10, 2017
Moves ledger notification into separate files
bsclifton
added a commit
that referenced
this pull request
Nov 10, 2017
Moves ledger notification into separate files
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -ito squash commits (if needed).Resolves #11876
Auditors:
Test Plan: covered via automated tests
Reviewer Checklist:
Tests