Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

remove tab page index update from WINDOW_CLOSE_FRAME #11903

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Conversation

cezaraugusto
Copy link
Contributor

Tab page update is already handled by APP_TAB_UPDATED.

fix #11902
Auditors: @bbondy
cc @srirambv

Test Plan:

  1. Open 3 tab pages
  2. Go back to tab page 1, select active tab
  3. Sequentially close
  4. Tab page shoudn't "flash"

Regression test:

  1. Closing/Opening tabs should update the tab page as expected

Copy link
Collaborator

@srirambv srirambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ manually tested and works fine.

@bbondy
Copy link
Member

bbondy commented Nov 13, 2017

++

@cezaraugusto cezaraugusto merged commit 0f0dcbe into master Nov 13, 2017
@cezaraugusto cezaraugusto deleted the ca---11902 branch November 13, 2017 16:29
cezaraugusto added a commit that referenced this pull request Nov 13, 2017
remove tab page index update from WINDOW_CLOSE_FRAME
cezaraugusto added a commit that referenced this pull request Nov 13, 2017
remove tab page index update from WINDOW_CLOSE_FRAME
cezaraugusto added a commit that referenced this pull request Nov 13, 2017
remove tab page index update from WINDOW_CLOSE_FRAME
@cezaraugusto
Copy link
Contributor Author

master 0f0dcbe
0.21.x ad3c42a
0.20.x 6b6e66b
0.19.x 87022b6

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

afte closing a tab, tab pages quick switch to the wrong index
4 participants