This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Exclude cookies from google.com domain #12171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12171 +/- ##
==========================================
- Coverage 56.21% 56.21% -0.01%
==========================================
Files 280 280
Lines 27519 27521 +2
Branches 4486 4486
==========================================
+ Hits 15470 15471 +1
- Misses 12049 12050 +1
|
alexwykoff
modified the milestones:
0.20.x Hotfix 3 (Ledger improvments),
0.21.x (Beta Channel)
fix #11401 Auditors: @bsclifton, @bbondy Test Plan: 1. #11401 (comment) 2. #11647 (comment) 3. #11401 (comment) 4. 4.a Clear cookies on FF and Chrome, login to gmail account 1 and account 2 4.b Close FF and Chrome, Open Brave (clean profile) 4.c Import cookies only from FF and Chrome 4.d Navigate to mail.google.com --> you have to enter password for account 1 and account 2 (but no 2FA) 4.e Import cookies from FF and Chrome again, refresh gmail page (you will have to enter password again to login both accounts) 4.f Logout and you will see login page with both accounts loggout (no cookie mismatch error) 5. unit test
bsclifton
force-pushed
the
issue-11401
branch
from
74f4b11 to
67b3941
Compare
bsclifton
approved these changes
Feb 8, 2018
bsclifton
added a commit
that referenced
this pull request
Feb 8, 2018
Exclude cookies from google.com domain
bsclifton
added a commit
that referenced
this pull request
Feb 8, 2018
Exclude cookies from google.com domain
|
yeah, it must be that because you can't read the encrypted cookie value |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #11401
Auditors: @bsclifton, @bbondy
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
.google.com cookie mismatch after import #11401 (comment)
Redo exception to cover Chrome's case #11647 (comment)
.google.com cookie mismatch after import #11401 (comment)
4.a Clear cookies on FF and Chrome, login to gmail account 1 and account 2
4.b Close FF and Chrome, Open Brave (clean profile)
4.c Import cookies only from FF and Chrome
4.d Navigate to mail.google.com --> you have to enter password for
account 1 and account 2 (but no 2FA)
4.e Import cookies from FF and Chrome again, refresh gmail page
(you will have to enter password again to login both accounts)
4.f Logout and you will see login page with both accounts loggout
(no cookie mismatch error)
npm run unittest -- --grep="shouldSkipCookie"Reviewer Checklist:
Tests