Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Using composition event to detect IME composition stage ends #12172

Merged
merged 1 commit into from
Feb 9, 2018
Merged

Using composition event to detect IME composition stage ends #12172

merged 1 commit into from
Feb 9, 2018

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Dec 4, 2017 •
edited by bsclifton
Loading

fix #9139

Auditors: @bsclifton, @bbondy

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

(Use Google as search engine will emphasize the effect)

  1. Go to Preferences > Search
  2. Set Google as default search engine
  3. Enable Autocomplete search terms as you type
  4. Make sure you have IME which has composition state
    (like Zhuyin in Chinese, some Japanese IME)
  5. Enter the characters in the IME, make sure doing some
    add/remove/select characters before ending composition state
    (mostly pressing enter)
  6. Autocomplete will show only after you complete the words/sentences

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@darkdh darkdh self-assigned this Dec 4, 2017
@darkdh darkdh requested review from bbondy and bsclifton December 4, 2017 23:03
@darkdh
Copy link
Member Author

darkdh commented Dec 4, 2017

@luixxiul this PR requires you to test Japanese IME

@luixxiul luixxiul mentioned this pull request Dec 5, 2017
Closed
@bsclifton bsclifton added this to the 0.21.x (Developer Channel) milestone Jan 2, 2018
@darkdh @bsclifton
Using composition event to detect IME composition stage ends
59e39ad 
fix #9139

Auditors: @bsclifton, @bbondy

Test Plan:

1. Make sure you have IME which has composition state
(like Zhuyin in Chinese, some Japanese IME)
2. Enter the characters in the IME, make sure doing some
add/remove/select characters before ending composition state
(mostly pressing enter)
3. Autocomplete will show only after you complete the words/sentences
bsclifton
bsclifton approved these changes Feb 9, 2018
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! 我超愛！！❤️

@bsclifton bsclifton merged commit aa970e8 into master Feb 9, 2018
@bsclifton bsclifton deleted the issue-9139 branch February 9, 2018 05:37
@bbondy
Copy link
Member

bbondy commented Feb 9, 2018

我也喜欢这个变化，安东尼是我的英雄。他做了很棒的工作。

bsclifton added a commit that referenced this pull request Feb 9, 2018
@bsclifton
Merge pull request #12172 from brave/issue-9139
cfe8fb9 
Using composition event to detect IME composition stage ends
bsclifton added a commit that referenced this pull request Feb 9, 2018
@bsclifton
Merge pull request #12172 from brave/issue-9139
6302637 
Using composition event to detect IME composition stage ends
@bsclifton
Copy link
Member

master aa970e8
0.22.x cfe8fb9
0.21.x 6302637

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@bbondy bbondy Awaiting requested review from bbondy

Assignees

@darkdh darkdh

Labels
bug feature/URLbar l10n PR/needs-QA-attention ☕
Projects
None yet
Milestone
0.22.x (Release Channel)
Development

Successfully merging this pull request may close these issues.

When using IME results are shown before selection is made
3 participants
@darkdh @bbondy @bsclifton