Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix time zone unittest failure on Travis #12192

Merged
merged 1 commit into from
Dec 5, 2017
Merged

Fix time zone unittest failure on Travis #12192

merged 1 commit into from
Dec 5, 2017

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Dec 5, 2017 •
edited by bsclifton
Loading

Fix #12191 by using a time that is 11/14 in both US local time (what most developers are using) and UTC (what Travis is probably using).

Test plan: unittest should pass in Travis

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@diracdeltas
Account for time zone discrepancy on Travis
6a1bfa4 
Fix #12191 by using a time that is 11/14 in both US local time (what most developers are using) and UTC (what Travis is probably using).

Test plan: unittest should pass in Travis
@diracdeltas diracdeltas self-assigned this Dec 5, 2017
@diracdeltas diracdeltas requested a review from bsclifton December 5, 2017 23:22
@diracdeltas diracdeltas requested a review from aekeus December 5, 2017 23:29
@diracdeltas diracdeltas changed the title Account for time zone discrepancy on Travis Fix time zone unittest on Travis Dec 5, 2017
@diracdeltas diracdeltas changed the title Fix time zone unittest on Travis Fix time zone unittest failure on Travis Dec 5, 2017
@diracdeltas
Copy link
Member Author

unittest is passing now: https://travis-ci.org/brave/browser-laptop/jobs/312134233#L6120

bsclifton
bsclifton approved these changes Dec 5, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 46b5387 into master Dec 5, 2017
@bsclifton bsclifton deleted the fix/time-zone-unittest branch December 5, 2017 23:42
bsclifton added a commit that referenced this pull request Dec 5, 2017
@bsclifton
Merge pull request #12192 from brave/fix/time-zone-unittest
ff6a7aa 
Fix time zone unittest failure on Travis
bsclifton added a commit that referenced this pull request Dec 5, 2017
@bsclifton
Merge pull request #12192 from brave/fix/time-zone-unittest
5998a9c 
Fix time zone unittest failure on Travis
bsclifton added a commit that referenced this pull request Dec 5, 2017
@bsclifton
Merge pull request #12192 from brave/fix/time-zone-unittest
9835af6 
Fix time zone unittest failure on Travis
@bsclifton
Copy link
Member

master 46b5387
0.21.x ff6a7aa
0.20.x 5998a9c
0.19.x 9835af6

@bsclifton bsclifton modified the milestones: 0.19.x Hotfix 7 (Release channel), 0.19.x + C63 (Release Channel) Dec 7, 2017
@bsclifton bsclifton modified the milestones: 0.19.x + C63 (Release Channel), 0.19.x Private Search Dec 14, 2017
@diracdeltas diracdeltas mentioned this pull request Dec 21, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@aekeus aekeus Awaiting requested review from aekeus

Assignees

@diracdeltas diracdeltas

Labels
automated-tests QA/no-qa-needed
Projects
None yet
Milestone
0.19.x Hotfix 7 (Release channel)
Development

Successfully merging this pull request may close these issues.
2 participants
@diracdeltas @bsclifton