This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 973
Add new LEDGER_NO_DELAY flag to help make QA easier #12251
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12251 +/- ##
==========================================
- Coverage 55.3% 55.24% -0.06%
==========================================
Files 276 276
Lines 26647 26659 +12
Branches 4294 4297 +3
==========================================
- Hits 14738 14729 -9
- Misses 11909 11930 +21
|
srirambv
approved these changes
Dec 11, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ Manual test plan works
NejcZdovc
approved these changes
Dec 11, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good to me
bsclifton
added a commit
that referenced
this pull request
Dec 11, 2017
Add new LEDGER_NO_DELAY flag to help make QA easier
bsclifton
added a commit
that referenced
this pull request
Dec 11, 2017
Add new LEDGER_NO_DELAY flag to help make QA easier
bsclifton
added a commit
that referenced
this pull request
Dec 11, 2017
Add new LEDGER_NO_DELAY flag to help make QA easier
bsclifton
modified the milestones:
0.19.x + C63 (Release Channel),
0.19.x Private Search
Dec 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12249
Auditors: @srirambv, @mrose17
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
LEDGER_NO_DELAY=true
andLEDGER_VERBOSE=true
run
method runs every 5 seconds. You should see a message like:LEDGER_NO_DELAY=true
Reviewer Checklist:
Tests