This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Remove unnecessary hosts from Brave index*.html CSP #12268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jumde
previously approved these changes
Dec 13, 2017
Removes all search provider autocomplete hosts and the following hosts from the connect-src directive: https://s3.amazonaws.com/adblock-data/ https://s3.amazonaws.com/safe-browsing-data/ https://s3.amazonaws.com/tracking-protection-data/ https://s3.amazonaws.com/https-everywhere-data/ https://brave-download.global.ssl.fastly.net https://brave-laptop-updates.global.ssl.fastly.net https://laptop-updates-pre.brave.com https://brave-laptop-updates-pre.brave.com These are not necessary to whitelist in CSP since they are only connected to from the main process, not the renderer process. fix #12263 Test Plan: 1. automated test passes 2. Delete httpse.json, *.dat, and `Extensions/jdbefljfgobbmcidnmpjamcbhnbphjnb/` in your brave APP_DATA directory (ex: `/Users/yan/Library/Application Support/Brave`) 3. Build a package if not running from a pre-packaged version of brave: `CHANNEL=dev npm run build-package` 4. Open the packaged version of Brave 5. Click 'Check for updates' from the file menu. It should show that no updates are available instead of an error. 6. Make sure opening a PDF works 7. Make sure HTTPS Everywhere works using https://https-everywhere.badssl.com/ 8. Go to settings -> turn on `Autocomplete search term as you type`. Type some words in the URL bar and you should see the query autocompleted.
diracdeltas
force-pushed
the
feature/csp-restrictions
branch
from
48e7e4b
to
ccb6ad6
Compare
|
@jumde i pushed a commit to remove the outdated TODO. please re-review / approve, thanks |
jumde
approved these changes
Dec 15, 2017
diracdeltas
added a commit
that referenced
this pull request
Dec 15, 2017
Remove unnecessary hosts from Brave index*.html CSP
diracdeltas
added a commit
that referenced
this pull request
Dec 15, 2017
Remove unnecessary hosts from Brave index*.html CSP
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all search provider autocomplete hosts and the following hosts from the connect-src directive: https://s3.amazonaws.com/adblock-data/ https://s3.amazonaws.com/safe-browsing-data/ https://s3.amazonaws.com/tracking-protection-data/ https://s3.amazonaws.com/https-everywhere-data/ https://brave-download.global.ssl.fastly.net https://brave-laptop-updates.global.ssl.fastly.net https://laptop-updates-pre.brave.com https://brave-laptop-updates-pre.brave.com
These are not necessary to whitelist in CSP since they are only connected to from the main process, not the renderer process.
fix #12263
Test Plan:
Extensions/jdbefljfgobbmcidnmpjamcbhnbphjnb/in your brave APP_DATA directory (ex:/Users/yan/Library/Application Support/Brave)CHANNEL=dev npm run build-packageAutocomplete search term as you type. Type some words in the URL bar and you should see the query autocompleted.Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests