Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes use case where passphrase is empty #12286

Merged
merged 1 commit into from
Dec 22, 2017

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Dec 14, 2017

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Partly fixes #11383

Auditors:

Test Plan: covered with automated tests

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc
Copy link
Contributor Author

@bsclifton can you please help me out with this spy that I commented out. Thank you

@codecov-io
Copy link

codecov-io commented Dec 14, 2017

Codecov Report

Merging #12286 into master will increase coverage by 0.59%.
The diff coverage is 87.5%.

@@            Coverage Diff             @@
##           master   #12286      +/-   ##
==========================================
+ Coverage   55.28%   55.88%   +0.59%     
==========================================
  Files         276      277       +1     
  Lines       26744    27632     +888     
  Branches     4311     4741     +430     
==========================================
+ Hits        14786    15442     +656     
- Misses      11958    12190     +232
Flag Coverage Δ
#unittest 55.88% <87.5%> (+0.59%) ⬆️
Impacted Files Coverage Δ
app/browser/api/ledger.js 52.07% <87.5%> (+1.47%) ⬆️
app/renderer/components/common/switchControl.js 82.66% <0%> (-2.7%) ⬇️
js/about/preferences.js 44.72% <0%> (-0.4%) ⬇️
app/common/constants/settingsEnums.js 100% <0%> (ø) ⬆️
js/constants/windowConstants.js 100% <0%> (ø) ⬆️
app/renderer/components/styles/global.js 100% <0%> (ø) ⬆️
app/browser/activeTabHistory.js 90.32% <0%> (ø)
js/actions/windowActions.js 5.02% <0%> (+0.16%) ⬆️
app/renderer/components/common/messageBox.js 88.34% <0%> (+0.59%) ⬆️
... and 14 more

@NejcZdovc
Copy link
Contributor Author

thx @bsclifton tests are now fixed, ready for the review

@bsclifton bsclifton modified the milestones: 0.19.x Hotfix 9, 0.21.x (Developer Channel) Dec 20, 2017
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Dec 21, 2017
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix 😄 👍

@bsclifton bsclifton merged commit 8745727 into brave:master Dec 22, 2017
bsclifton added a commit that referenced this pull request Dec 22, 2017
Fixes use case where passphrase is empty
bsclifton added a commit that referenced this pull request Dec 22, 2017
Fixes use case where passphrase is empty
@bsclifton
Copy link
Member

master 8745727
0.21.x 415747f
0.20.x 39bed6c

bsclifton added a commit that referenced this pull request Jan 9, 2018
Fixes use case where passphrase is empty
@bsclifton
Copy link
Member

merged to 0.19.x with 395e12b

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restoring a wallet backup (wallet v2) sometimes fails and then only shows "a"
3 participants