This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 975
Fixes use case where passphrase is empty #12286
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@bsclifton can you please help me out with this spy that I commented out. Thank you |
Codecov Report
@@ Coverage Diff @@
## master #12286 +/- ##
==========================================
+ Coverage 55.28% 55.88% +0.59%
==========================================
Files 276 277 +1
Lines 26744 27632 +888
Branches 4311 4741 +430
==========================================
+ Hits 14786 15442 +656
- Misses 11958 12190 +232
|
Auditors: Test Plan:
NejcZdovc
force-pushed
the
hotfix/#11383-passphrase
branch
from
December 14, 2017 19:00
6fcb96e
to
04506f6
Compare
thx @bsclifton tests are now fixed, ready for the review |
bsclifton
approved these changes
Dec 22, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great fix 😄 👍
bsclifton
added a commit
that referenced
this pull request
Dec 22, 2017
Fixes use case where passphrase is empty
bsclifton
added a commit
that referenced
this pull request
Dec 22, 2017
Fixes use case where passphrase is empty
bsclifton
added a commit
that referenced
this pull request
Jan 9, 2018
Fixes use case where passphrase is empty
merged to 0.19.x with 395e12b |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -i
to squash commits (if needed).Partly fixes #11383
Auditors:
Test Plan: covered with automated tests
Reviewer Checklist:
Tests