-
Notifications
You must be signed in to change notification settings - Fork 975
Conversation
98e642f
to
54fa9b8
Compare
blocked on brave-intl/bat-client#33 |
54fa9b8
to
7d40cc2
Compare
7d40cc2
to
8e89d1a
Compare
7f29603
to
c2a6e3b
Compare
Codecov Report
@@ Coverage Diff @@
## master #12287 +/- ##
==========================================
+ Coverage 55.95% 55.97% +0.01%
==========================================
Files 278 278
Lines 27029 27034 +5
Branches 4373 4372 -1
==========================================
+ Hits 15125 15133 +8
+ Misses 11904 11901 -3
|
c2a6e3b
to
78c82c6
Compare
78c82c6
to
5492ea0
Compare
app/browser/api/ledger.js
Outdated
if (verifiedTimeoutId) { | ||
clearInterval(verifiedTimeoutId) | ||
} | ||
verifiedTimeoutId = setInterval(getPublisherTimestamp, 1 * ledgerUtil.milliseconds.hour) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to call clearInterval
and set to false when payments is turned off?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's just for safety, because we trigger boot via action, so there could be race problem if we trigger interval in other place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed base on our slack conversation
assert(checkVerifiedStatusSpy.withArgs(sinon.match.any, 'clifton.io', 20).calledOnce) | ||
}) | ||
|
||
it('check mulitple publishers', function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/mulitple/multiple 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two items noted (concern about clearing interval and misspelling)
Changes work great as expected- Code changes look good too 😄 👍
5492ea0
to
79ed617
Compare
79ed617
to
dbbc0da
Compare
Resolves brave#12272 Auditors: Test Plan:
dbbc0da
to
b96a73f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Would be nice to have getPublisherTimestamp
return if payments is disabled... but that is an edge case which seems pretty minimal (and would only happen once an hour until closed).
Submitter Checklist:
git rebase -i
to squash commits (if needed).Resolves #12272
Auditors:
Test Plan:
Plan 1
Plan 2
Reviewer Checklist:
Tests