-
Notifications
You must be signed in to change notification settings - Fork 975
Fixes formatting for YT on shields page #12299
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12299 +/- ##
==========================================
- Coverage 56.77% 56.72% -0.06%
==========================================
Files 285 285
Lines 29042 29075 +33
Branches 4800 4806 +6
==========================================
+ Hits 16489 16493 +4
- Misses 12553 12582 +29
|
Verified the following:
|
added session conversion as well. @bsclifton wdyt, should we go with versions like I did or should we use timestamp check? |
app/sessionStore.js
Outdated
try { runWidevineCleanup = compareVersions(data.lastAppVersion, '0.18.25') < 1 } catch (e) {} | ||
try { | ||
runWidevineCleanup = compareVersions(data.lastAppVersion, '0.18.25') < 1 | ||
formatPublishers = compareVersions(data.lastAppVersion, '0.22.0') < 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to change this to 0.19.118, but is here for testing purposes for now
blocked on #13056 |
67dd8fe
to
28674ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after rebase, please ping me.
28674ce
to
e2b6de1
Compare
6a0d923
to
9058c68
Compare
@mrose17 ready |
Resolves brave#12271 Auditors: Test Plan:
9058c68
to
9f0f748
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
++
Fixes formatting for YT on shields page
Fixes formatting for YT on shields page
Do not squash commits
Submitter Checklist:
git rebase -i
to squash commits (if needed).Resolves #12271
Test Plan: defined in #12271
New layout
Reviewer Checklist:
Tests