Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix unittest for people in New Zealand #12372

Merged
merged 1 commit into from
Dec 22, 2017
Merged

Fix unittest for people in New Zealand #12372

merged 1 commit into from
Dec 22, 2017

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Dec 22, 2017

fix #12370 by changing the test to use a time of day that is on the same day in all timezones

Test Plan:
Change local timezone to New Zealand
unittests should pass

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

fix #12370 by changing the test to use a time of day that is on the same day in all timezones

Test Plan:
Change local timezone to New Zealand
unittests should pass
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks 👍

@petemill petemill merged commit 9588ac2 into master Dec 22, 2017
@luixxiul luixxiul added this to the 0.22.x (Nightly Channel) milestone Dec 22, 2017
@diracdeltas diracdeltas deleted the fix/12370 branch December 29, 2017 02:08
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'update date handling' unit tests fail for some timezones
5 participants