Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix PDF reloading #12431

Merged
merged 1 commit into from
Dec 29, 2017
Merged

Fix PDF reloading #12431

merged 1 commit into from
Dec 29, 2017

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Dec 28, 2017

fix #12408

Test plan:

  1. load any PDF
  2. hit reload
  3. it should reload the PDF instead of 'file not found'

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

fix #12408

Test plan:
1. load any PDF
2. hit reload
3. it should reload the PDF instead of 'file not found'
@diracdeltas diracdeltas self-assigned this Dec 28, 2017
@diracdeltas diracdeltas requested a review from petemill December 28, 2017 16:32
@diracdeltas diracdeltas added this to the 0.20.x (Beta Channel) milestone Dec 28, 2017
@bsclifton bsclifton self-requested a review December 29, 2017 21:07
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified broken before and fixed after using https://basicattentiontoken.org/BasicAttentionTokenWhitePaper-4.pdf

😄 👍

@bsclifton bsclifton merged commit f7d8df6 into master Dec 29, 2017
@bsclifton bsclifton deleted the fix/12408 branch December 29, 2017 21:41
bsclifton added a commit that referenced this pull request Dec 29, 2017
bsclifton added a commit that referenced this pull request Dec 29, 2017
@bsclifton
Copy link
Member

master f7d8df6
0.21.x 8dfe39f
0.20.x ec99115

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reload tab doesn't load PDF
3 participants