Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes publisher exclude after restart #12767

Merged
merged 1 commit into from
Feb 19, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jan 22, 2018

Resolves #12766

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

defined in #12766

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc added this to the 0.20.x Hotfix 1 milestone Jan 22, 2018
@NejcZdovc NejcZdovc self-assigned this Jan 22, 2018
@NejcZdovc NejcZdovc requested a review from bsclifton January 22, 2018 06:43
@codecov-io
Copy link

codecov-io commented Jan 22, 2018

Codecov Report

Merging #12767 into master will decrease coverage by 0.03%.
The diff coverage is 62.5%.

@@            Coverage Diff             @@
##           master   #12767      +/-   ##
==========================================
- Coverage   56.15%   56.12%   -0.04%     
==========================================
  Files         279      279              
  Lines       27899    27908       +9     
  Branches     4565     4567       +2     
==========================================
- Hits        15666    15662       -4     
- Misses      12233    12246      +13
Flag Coverage Δ
#unittest 56.12% <62.5%> (-0.04%) ⬇️
Impacted Files Coverage Δ
app/browser/api/ledger.js 60.14% <62.5%> (-0.02%) ⬇️
js/stores/appStoreRenderer.js 91.66% <0%> (-8.34%) ⬇️
app/renderer/components/reduxComponent.js 57.75% <0%> (-3.45%) ⬇️
js/stores/windowStore.js 27.65% <0%> (-0.3%) ⬇️

@alexwykoff alexwykoff modified the milestones: 0.20.x Hotfix 3 (Ledger improvments), 0.21.x (Beta Channel) Feb 6, 2018
@bsclifton bsclifton force-pushed the hotfix/#12766-include branch from 41a3d76 to 7f94309 Compare February 19, 2018 07:17
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated test steps after confusion 😄 Changes works great!

@bsclifton bsclifton merged commit 0777c0e into brave:master Feb 19, 2018
bsclifton added a commit that referenced this pull request Feb 19, 2018
Fixes publisher exclude after restart
bsclifton added a commit that referenced this pull request Feb 19, 2018
Fixes publisher exclude after restart
@bsclifton
Copy link
Member

master 0777c0e
0.22.x 833e0a4
0.21.x b985e77

@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Beta Channel), 0.21.x (Twitch) Feb 24, 2018
NejcZdovc pushed a commit that referenced this pull request Feb 24, 2018
@NejcZdovc
Copy link
Contributor Author

0.21 twitch 2790d0d

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants