Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Remove Masthead Ads on YouTube #12846

Merged
merged 1 commit into from
Feb 8, 2018
Merged

Remove Masthead Ads on YouTube #12846

merged 1 commit into from
Feb 8, 2018

Conversation

jonathansampson
Copy link
Collaborator

@jonathansampson jonathansampson commented Jan 25, 2018

Fixes #12845

youtube-masthead-ad-gone

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  1. Navigate to youtube.com
  2. Confirm that large empty ad-container is not visible

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bsclifton bsclifton added this to the 0.23.x (Nightly Channel) milestone Feb 8, 2018
@bsclifton bsclifton self-requested a review February 8, 2018 17:27
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! 😄 👍 ++

@bsclifton bsclifton merged commit 8603fec into master Feb 8, 2018
@bsclifton bsclifton deleted the issue-12845 branch February 8, 2018 20:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants