Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Adds required prerequisites needed for building on Solus #13004

Merged
merged 2 commits into from
Mar 2, 2018
Merged

Adds required prerequisites needed for building on Solus #13004

merged 2 commits into from
Mar 2, 2018

Conversation

Jacalz
Copy link
Contributor

@Jacalz Jacalz commented Feb 3, 2018

Submitter Checklist:

Test Plan:
n/a, this should work and I have tested it myself!

@Jacalz
Copy link
Contributor Author

Jacalz commented Feb 28, 2018

This is ready for review now @bsclifton 👍

@codecov-io
Copy link

codecov-io commented Feb 28, 2018

Codecov Report

Merging #13004 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13004      +/-   ##
==========================================
- Coverage   56.13%   55.97%   -0.16%     
==========================================
  Files         279      282       +3     
  Lines       27332    28211     +879     
  Branches     4446     4642     +196     
==========================================
+ Hits        15343    15792     +449     
- Misses      11989    12419     +430
Flag Coverage Δ
#unittest 55.97% <ø> (-0.16%) ⬇️
Impacted Files Coverage Δ
app/renderer/components/reduxComponent.js 57.75% <0%> (-33.02%) ⬇️
app/browser/webContentsCache.js 54.76% <0%> (-20.24%) ⬇️
app/browser/activeTabHistory.js 77.77% <0%> (-12.55%) ⬇️
app/common/lib/fetchSearchSuggestions.js 22.85% <0%> (-10.48%) ⬇️
js/stores/appStoreRenderer.js 91.66% <0%> (-8.34%) ⬇️
app/common/state/updateState.js 94.11% <0%> (-5.89%) ⬇️
app/common/cache/ledgerVideoCache.js 95.45% <0%> (-4.55%) ⬇️
app/renderer/components/preferences/paymentsTab.js 71.22% <0%> (-4.22%) ⬇️
app/browser/windows.js 33.27% <0%> (-3.8%) ⬇️
app/browser/api/ledgerNotifications.js 70.95% <0%> (-3.61%) ⬇️
... and 49 more

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 33a6d16 into brave:master Mar 2, 2018
@bsclifton bsclifton removed this from the Completed work milestone Mar 2, 2018
@Jacalz
Copy link
Contributor Author

Jacalz commented Mar 2, 2018

Yay! Thanks @bsclifton 👍

@Jacalz Jacalz deleted the build-from-source-on-solus branch March 2, 2018 06:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants