This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 973
Disables Action column header in ledger payments table #13076
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions column on the ledger table
@NejcZdovc let me know how this looks, and if hard coding would be preferable in this case Simplest solution there would be doing :) Thanks |
Codecov Report
@@ Coverage Diff @@
## master #13076 +/- ##
==========================================
+ Coverage 56.21% 56.22% +<.01%
==========================================
Files 280 280
Lines 27521 27522 +1
Branches 4486 4487 +1
==========================================
+ Hits 15471 15473 +2
+ Misses 12050 12049 -1
|
NejcZdovc
changed the title
Fixing Issue #13074, allows for non sortable columns, excluding the A…
Disables Action column header in ledger payments table
Feb 9, 2018
NejcZdovc
approved these changes
Feb 9, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ Your approach is for sure more elegant, because we can reuse this in other tables. Great job 👍
NejcZdovc
added a commit
that referenced
this pull request
Feb 9, 2018
Disables Action column header in ledger payments table
NejcZdovc
added a commit
that referenced
this pull request
Feb 9, 2018
Disables Action column header in ledger payments table
Awesome! Thanks @NejcZdovc :) |
0.21 twitch a04e202 |
NejcZdovc
added a commit
that referenced
this pull request
Feb 24, 2018
Disables Action column header in ledger payments table
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13074
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Ensure that the Actions column on the ledger table in about:preferences#payments is neither clickable nor sortable.
Ensure that other implementations of the SortableTable such as on about:history work as expected without error.
Reviewer Checklist:
Tests
As opposed to hard coding in something to exclude the Actions column from being clickable/sortable, I thought it would be helpful to have a nonSortableColumns property on the component for future column exclusions as more tables may be added. It is implemented in such away that not having the property does not break anything or produce any unexpected behavior.