Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Make error message darker #13180

Merged
merged 1 commit into from
Feb 21, 2018
Merged

Make error message darker #13180

merged 1 commit into from
Feb 21, 2018

Conversation

srirambv
Copy link
Collaborator

@srirambv srirambv commented Feb 19, 2018

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Fixes #13162

Before
image
After
image

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@srirambv srirambv added feature/about-pages 0.23.x issue first seen in 0.23.x labels Feb 19, 2018
@srirambv srirambv added this to the 0.23.x (Nightly Channel) milestone Feb 19, 2018
@srirambv srirambv self-assigned this Feb 19, 2018
@srirambv srirambv requested review from bsclifton and darkdh February 19, 2018 04:41
@darkdh
Copy link
Member

darkdh commented Feb 19, 2018

I think we should loop in @bradleyrichter

@darkdh darkdh requested review from bradleyrichter and removed request for darkdh February 19, 2018 04:45
Copy link
Member

@diracdeltas diracdeltas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this looks way better. the old text was not readable for people with color-contrast related vision problems.

@alexwykoff
Copy link
Contributor

👍

@bsclifton bsclifton merged commit 1b8741c into brave:master Feb 21, 2018
@srirambv srirambv deleted the errortext branch February 22, 2018 03:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
0.23.x issue first seen in 0.23.x feature/about-pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants