This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Prevent borkiness when session-store file is missing perWindowState[].closedFrames #13265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13265 +/- ##
==========================================
+ Coverage 56.01% 56.24% +0.23%
==========================================
Files 282 282
Lines 28211 28221 +10
Branches 4642 4646 +4
==========================================
+ Hits 15801 15873 +72
+ Misses 12410 12348 -62
|
…o perWindowState[].closedFrames property, which would then cause the app never recover, even after restart. Fix #13261, although since that's not reproducible I'm not sure the moving-tab keyboard shortcut neccessarily caused it, but something did, and this will allow recovery in that situation.
bsclifton
force-pushed
the
fix/13261-borked-closedframes
branch
from
52e4baf to
9fb671b
Compare
…nning filterNot (small code tweak) Auditors: @petemill
- Add unit tests for APP_SHOW_NOTIFICATION and APP_HIDE_NOTIFICATION - deregister mock from previous commit (windowStateTest). Forgot that :) Auditors: @petemill
bsclifton
reviewed
Mar 1, 2018
| if (style) { | ||
| const styleIndex = notifications.findLastIndex((notification) => { | ||
| return notification.get('options').get('style') === style | ||
| { |
There was a problem hiding this comment.
added { so that variables defined here are scoped
bsclifton
reviewed
Mar 1, 2018
|
|
||
| // Insert notification next to those with the same style, or at the end | ||
| let insertIndex = notifications.size | ||
| const style = action.detail |
There was a problem hiding this comment.
updated this to handle detail being falsey
bsclifton
reviewed
Mar 1, 2018
| return notification.get('message') === action.message | ||
| })) | ||
| break | ||
| { |
bsclifton
approved these changes
Mar 1, 2018
petemill
added a commit
that referenced
this pull request
Mar 1, 2018
Prevent borkiness when session-store file is missing perWindowState[].closedFrames
|
0.22.x 4388e3c |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would then cause the app never recover, even after restart. Especially with an
about:errortab in the session-store, which would immediately causeappActions.removeHistorySiteto fire when it fails to load. The reducer of that action relied onwindowState.closedFramesbeing there. This changes it to not rely on that.Fix #13261, although since that's not reproducible I'm not sure the moving-tab keyboard shortcut necessarily caused it, but something did, and this will allow recovery in that situation.
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests