Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes torrent merge #13269

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Fixes torrent merge #13269

merged 1 commit into from
Feb 23, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Feb 23, 2018

Resolves #13268

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Plan a

  1. enable torrent viewer
  2. download a torrent
  3. make sure that it's opened with our viewer

Plan b

  1. disable torrent viewer
  2. download a torrent
  3. torrent file should be downloaded

Plan c
#8452 (comment)

Plan d
#8325 (comment)

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Resolves brave#13268

Auditors:

Test Plan:
@NejcZdovc NejcZdovc added this to the 0.21.x (Beta Channel) milestone Feb 23, 2018
@NejcZdovc NejcZdovc self-assigned this Feb 23, 2018
@codecov-io
Copy link

codecov-io commented Feb 23, 2018

Codecov Report

Merging #13269 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #13269      +/-   ##
==========================================
- Coverage   55.93%   55.89%   -0.04%     
==========================================
  Files         281      281              
  Lines       27856    27856              
  Branches     4571     4571              
==========================================
- Hits        15580    15571       -9     
- Misses      12276    12285       +9
Flag Coverage Δ
#unittest 55.89% <0%> (-0.04%) ⬇️
Impacted Files Coverage Δ
app/filtering.js 17.92% <0%> (ø) ⬆️
js/stores/appStoreRenderer.js 91.66% <0%> (-8.34%) ⬇️
app/renderer/components/reduxComponent.js 57.75% <0%> (-3.45%) ⬇️
js/stores/windowStore.js 27.65% <0%> (-0.3%) ⬇️

@bsclifton bsclifton merged commit 989a53e into brave:master Feb 23, 2018
bsclifton added a commit that referenced this pull request Feb 23, 2018
bsclifton added a commit that referenced this pull request Feb 23, 2018
@bsclifton
Copy link
Member

master 989a53e
0.22.x 745d169
0.21.x 9975c0a

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants