Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Ensure a window with no frames is not the last remembered window to restore on next startup #13291

Merged
merged 2 commits into from
Mar 2, 2018

Conversation

petemill
Copy link
Member

Fix #13278

Also introduces a new flag --disable-buffer-window, e.g. npm start -- --disable-buffer-window which can be useful for comparing any issues.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

On #13278

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@petemill petemill added OS/Windows regression 0.21.x issue first seen in 0.21.x labels Feb 24, 2018
@petemill petemill added this to the 0.21.x (Beta Channel) milestone Feb 24, 2018
@petemill petemill self-assigned this Feb 24, 2018
@codecov-io
Copy link

codecov-io commented Feb 24, 2018

Codecov Report

Merging #13291 into master will decrease coverage by <.01%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##           master   #13291      +/-   ##
==========================================
- Coverage   56.24%   56.23%   -0.01%     
==========================================
  Files         282      282              
  Lines       28221    28227       +6     
  Branches     4646     4648       +2     
==========================================
+ Hits        15873    15874       +1     
- Misses      12348    12353       +5
Flag Coverage Δ
#unittest 56.23% <28.57%> (-0.01%) ⬇️
Impacted Files Coverage Δ
app/cmdLine.js 40% <100%> (+0.57%) ⬆️
app/sessionStoreShutdown.js 86.33% <100%> (ø) ⬆️
app/browser/windows.js 32.99% <9.09%> (-0.29%) ⬇️

@bsclifton bsclifton removed the 0.21.x issue first seen in 0.21.x label Feb 27, 2018
@bsclifton bsclifton force-pushed the fix/13278-windows-tab-session-restore branch from 63b5579 to 4369ede Compare March 1, 2018 23:12
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change works great (verified on Windows 7). Also verified --disable-buffer-window works as expected by using --debug-window-events 😄

Code change looks good too. Nice work 😄 👍

@bsclifton bsclifton merged commit 41294fc into master Mar 2, 2018
@bsclifton bsclifton deleted the fix/13278-windows-tab-session-restore branch March 2, 2018 05:16
bsclifton added a commit that referenced this pull request Mar 2, 2018
…store

Ensure a window with no frames is not the last remembered window to restore on next startup
bsclifton added a commit that referenced this pull request Mar 2, 2018
…store

Ensure a window with no frames is not the last remembered window to restore on next startup
@bsclifton
Copy link
Member

master 41294fc
0.23.x 96a7e06
0.22.x 2b04656

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants