Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed issue #13256 - Removing or modifying URL will now hide EVC #13335

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Fixed issue #13256 - Removing or modifying URL will now hide EVC #13335

merged 1 commit into from
Feb 27, 2018

Conversation

jasonrsadler
Copy link
Contributor

@jasonrsadler jasonrsadler commented Feb 27, 2018

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

fix #13256

@codecov-io
Copy link

codecov-io commented Feb 27, 2018

Codecov Report

Merging #13335 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13335      +/-   ##
==========================================
- Coverage   56.01%   55.97%   -0.04%     
==========================================
  Files         282      282              
  Lines       28211    28211              
  Branches     4642     4642              
==========================================
- Hits        15801    15792       -9     
- Misses      12410    12419       +9
Flag Coverage Δ
#unittest 55.97% <ø> (-0.04%) ⬇️
Impacted Files Coverage Δ
js/stores/appStoreRenderer.js 91.66% <0%> (-8.34%) ⬇️
app/renderer/components/reduxComponent.js 57.75% <0%> (-3.45%) ⬇️
js/stores/windowStore.js 27.36% <0%> (-0.3%) ⬇️

@diracdeltas diracdeltas self-requested a review February 27, 2018 20:50
@diracdeltas diracdeltas added this to the 0.22.x (Developer Channel) milestone Feb 27, 2018
Copy link
Member

@diracdeltas diracdeltas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works! thanks @jasonrsadler

@jasonrsadler
Copy link
Contributor Author

Thanks for the direction @diracdeltas

Sorry for the prev botched PR

@bsclifton bsclifton merged commit 2ceda21 into brave:master Feb 27, 2018
bsclifton added a commit that referenced this pull request Feb 27, 2018
Fixed issue #13256 - Removing or modifying URL will now hide EVC
@bsclifton
Copy link
Member

master 2ceda21
0.22.x be6d2cf

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing URL doesn't remove the EVC details
4 participants