Reconcile is no longer triggered if there are no publishers in the ledger table.

[ryanml]

Fixes #13325

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

1. Clean install 0.21.16, do not visit any site
2. Enable payment and add funds to wallet
3. Change reconcile stamp to older date.
4. Confirm that the reconciliation does not process and that date is pushed back

Reviewer Checklist:

• Request a security/privacy review as needed if one was not already requested.

Tests

• Adequate test coverage exists to prevent regressions
• Tests should be independent and work correctly when run individually or as a suite ref
• New files have MPL2 license header

[ryanml]

@srirambv @NejcZdovc

[ryanml]

@NejcZdovc let me know if this is a change that makes more sense to implement in to the bat-client itself, and not browser-side. Thanks!

[NejcZdovc]

@ryanml well I think that solution is sadly not that simple. We need to define what actually happens in this case with contribution time should we push it back for 30 days or just fuzz it for couple of days. I think that if your table is empty I would push it back for 30 days. So we need to update reconcile timestamp.

[ryanml]

@NejcZdovc makes complete sense.

Would we just be updating delayTime in this case or setting setTimeUntilReconcile via the client?

Either way, I'll work something out and we can review from there :)

[NejcZdovc]

@ryanml we should set setTimeUntilReconcile

[codecov-io]

Codecov Report

Merging #13385 into master will decrease coverage by 0.14%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           master   #13385      +/-   ##
==========================================
- Coverage   56.78%   56.64%   -0.15%     
==========================================
  Files         285      285              
  Lines       29038    29034       -4     
  Branches     4803     4803              
==========================================
- Hits        16488    16445      -43     
- Misses      12550    12589      +39

Flag	Coverage Δ
#unittest	56.64% <93.75%> (-0.15%)	⬇️

Impacted Files	Coverage Δ
app/browser/api/ledger.js	60.46% <93.75%> (-1.46%)	⬇️
js/stores/appStoreRenderer.js	91.66% <0%> (-8.34%)	⬇️
app/renderer/components/reduxComponent.js	57.75% <0%> (-3.45%)	⬇️
js/stores/windowStore.js	28.46% <0%> (-0.3%)	⬇️
app/common/state/ledgerState.js	85.19% <0%> (+0.24%)	⬆️

[ryanml]

@NejcZdovc I think we're a little closer to the desired result now

[NejcZdovc]

Let's extract this block into separate function and just call this function here. Also please replace this block in other places that you can find it with this new function. You don't need to pass newReconcileTime, you can just pass null in, which will default to 30 days.

[ryanml]

@NejcZdovc changes pushed

[NejcZdovc]

let's extend this check to if (publishers.isEmpty() && client.isReadyToReconcile(synopsis)) {. This way we are not pushing back time every time run is called, but we push it back only once every month.

[ryanml]

@NejcZdovc good call, changes pushed

[NejcZdovc]

@ryanml let's just squash this and we are good to go

[ryanml]

@NejcZdovc squashed 👍 thanks for your guidance on this one!

[NejcZdovc]

Looks good to me ++

[NejcZdovc]

@ryanml sure, not a problem

[NejcZdovc]

master bc3262a
0.23 372c933
0.22 331000e