Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Note that Brave can be installed on Debian Stretch #13406

Merged
merged 1 commit into from
Mar 9, 2018
Merged

Note that Brave can be installed on Debian Stretch #13406

merged 1 commit into from
Mar 9, 2018

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Mar 8, 2018

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@fmarier
Copy link
Member Author

fmarier commented Mar 8, 2018

@cezaraugusto You were the last one to merge a README pull request, so I guess I should flag you?

@codecov-io
Copy link

codecov-io commented Mar 8, 2018

Codecov Report

Merging #13406 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13406      +/-   ##
==========================================
- Coverage   56.23%    56.2%   -0.04%     
==========================================
  Files         282      282              
  Lines       28240    28240              
  Branches     4651     4651              
==========================================
- Hits        15880    15871       -9     
- Misses      12360    12369       +9
Flag Coverage Δ
#unittest 56.2% <ø> (-0.04%) ⬇️
Impacted Files Coverage Δ
js/stores/appStoreRenderer.js 91.66% <0%> (-8.34%) ⬇️
app/renderer/components/reduxComponent.js 57.75% <0%> (-3.45%) ⬇️
js/stores/windowStore.js 28.48% <0%> (-0.3%) ⬇️

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 5d58f8d into brave:master Mar 9, 2018
@bsclifton
Copy link
Member

@fmarier thanks for the update 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants