increase version range for pinnedTopSites cleanup

[cezaraugusto]

Different fixes were tried for this but all needed to iterate over the list to check for duplicates and ended bulking startup time.

This fix is the same take as previous with a wider range of versions. This is better for performance as it does not iterate over the list on startup/every pin interaction but instead cleans the state at update time so no user-space affected.

fix #12941

Test Plan:

1. Hack your session-store-1 adding a few duplicated objects inside pinnedTopSites list.
2. Run Brave
3. Quit
4. Check session-store-1 file again. There should be no duplicates
5. Run Brave again. There should be no pinned top sites

Test Plan (QA specific):

1. Install 0.19.x - have a bunch of top sites
2. Upgrade to 0.20.30 which doesn't have the fix. Verify still broken
3. Update to this release (0.22.x) and verify issue is now fixed

[codecov-io]

Codecov Report

Merging #13429 into master will increase coverage by 0.01%.
The diff coverage is 87.5%.

@@            Coverage Diff             @@
##           master   #13429      +/-   ##
==========================================
+ Coverage   56.25%   56.26%   +0.01%     
==========================================
  Files         283      283              
  Lines       28353    28363      +10     
  Branches     4674     4675       +1     
==========================================
+ Hits        15950    15959       +9     
- Misses      12403    12404       +1

Flag	Coverage Δ
#unittest	56.26% <87.5%> (+0.01%)	⬆️

Impacted Files	Coverage Δ
app/sessionStore.js	88.22% <87.5%> (+0.02%)	⬆️

[bsclifton]

@cezaraugusto besides the dupes, this should fix folks who missed your fix (fixing their top sites).

Did we want to capture that scenario in the test plan? ex:

1. Install 0.19.x - have a bunch of top sites
2. Upgrade to 0.20.30 which doesn't have the fix. Verify still broken
3. Update to this release and verify issue is now fixed

[bsclifton]

Should we have another check for this, so it only runs once?

Specifically we could capture this in the state in an area called "migrations" (see example which was removed with ccee122#diff-b4e400e260f324745d12616a8c9c1fc6L377 - was removed since nothing else is using it).

When fix is ran you could set this value to current timestamp and default the value (in app/sessionStore.js) to undefined

[bsclifton]

Also, note to self: we'll want to update this version before we ship. We might want to create an issue to track that

[bsclifton]

Changes look good- left comment about having this only run once and asking about test plan. Let me know when it's ready for re-review I'll run the test plan 😄 👍

[cezaraugusto]

re #13429 (comment) I included your take (thanks) in the test plan. Most users did receive the fix, this PR specifically target all of them and unless someone manages to update from 0.19.x to something >0.22.00, all users should get this fix.

[bsclifton]

Thanks for the test plan update! 😄 👍 Great work, sir!

[bsclifton]

master 9e91ffe
0.23.x 23e50ad
0.22.x f1d4f72