Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes notification shown after toggle #13436

Merged
merged 1 commit into from
Mar 21, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Mar 13, 2018

Resolves #13287

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

defined in #13287

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@codecov-io
Copy link

codecov-io commented Mar 13, 2018

Codecov Report

Merging #13436 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #13436      +/-   ##
==========================================
- Coverage   56.25%   56.23%   -0.03%     
==========================================
  Files         283      283              
  Lines       28353    28358       +5     
  Branches     4674     4675       +1     
==========================================
- Hits        15950    15946       -4     
- Misses      12403    12412       +9
Flag Coverage Δ
#unittest 56.23% <100%> (-0.03%) ⬇️
Impacted Files Coverage Δ
app/common/state/ledgerState.js 84.46% <100%> (+0.19%) ⬆️
js/stores/appStoreRenderer.js 91.66% <0%> (-8.34%) ⬇️
app/renderer/components/reduxComponent.js 57.75% <0%> (-3.45%) ⬇️
js/stores/windowStore.js 28.48% <0%> (-0.3%) ⬇️

@bsclifton bsclifton added this to the Completed work milestone Mar 14, 2018
Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests were as expected.
13287

@mrose17 mrose17 self-requested a review March 14, 2018 21:52
Copy link
Member

@mrose17 mrose17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@NejcZdovc NejcZdovc modified the milestones: Completed work, 0.22.x (Beta Channel) Mar 21, 2018
@NejcZdovc NejcZdovc merged commit 49ba85c into brave:master Mar 21, 2018
NejcZdovc added a commit that referenced this pull request Mar 21, 2018
NejcZdovc added a commit that referenced this pull request Mar 21, 2018
@NejcZdovc
Copy link
Contributor Author

master 49ba85c
0.23 54e13a8
0.22 bd1d0ab

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants