Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Tabs are always autoDiscardable #13555

Merged

Conversation

petemill
Copy link
Member

@petemill petemill commented Mar 22, 2018

Fix faulty logic that would almost never have a tab become discarded automatically.
Fix #13547

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Fix faulty logic that would almost never have a tab become discarded automatically.
Fix brave#13547
@petemill petemill added this to the 0.22.x (Beta Channel) milestone Mar 22, 2018
@petemill petemill self-assigned this Mar 22, 2018
@codecov-io
Copy link

codecov-io commented Mar 22, 2018

Codecov Report

Merging #13555 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #13555      +/-   ##
==========================================
- Coverage   56.63%   56.59%   -0.04%     
==========================================
  Files         284      284              
  Lines       28731    28728       -3     
  Branches     4746     4744       -2     
==========================================
- Hits        16272    16260      -12     
- Misses      12459    12468       +9
Flag Coverage Δ
#unittest 56.59% <100%> (-0.04%) ⬇️
Impacted Files Coverage Δ
app/browser/tabs.js 23.68% <100%> (-0.21%) ⬇️
js/stores/appStoreRenderer.js 91.66% <0%> (-8.34%) ⬇️
app/renderer/components/reduxComponent.js 57.75% <0%> (-3.45%) ⬇️
js/stores/windowStore.js 28.46% <0%> (-0.3%) ⬇️

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Collaborator

@bridiver bridiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 75ec846 into brave:master Mar 22, 2018
bsclifton added a commit that referenced this pull request Mar 22, 2018
bsclifton added a commit that referenced this pull request Mar 22, 2018
@bsclifton
Copy link
Member

master 75ec846
0.23.x 5f11d5a
0.22.x 4a7830d

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants