Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes recovery dialog #13576

Merged
merged 1 commit into from
Mar 22, 2018
Merged

Fixes recovery dialog #13576

merged 1 commit into from
Mar 22, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Mar 22, 2018

Resolves #13424

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  1. clean profile
  2. enable payments
  3. close browser
  4. open ledger-state.json and modify seed (remove some of them)
  5. start browser again
  6. you should see an overlay
  7. clicking on recover should open recover dialog

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Resolves brave#13424

Auditors:

Test Plan:
@NejcZdovc NejcZdovc added this to the 0.22.x (Beta Channel) milestone Mar 22, 2018
@NejcZdovc NejcZdovc self-assigned this Mar 22, 2018
@NejcZdovc NejcZdovc requested a review from bsclifton March 22, 2018 23:34
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@NejcZdovc NejcZdovc merged commit 777291b into brave:master Mar 22, 2018
NejcZdovc added a commit that referenced this pull request Mar 22, 2018
NejcZdovc added a commit that referenced this pull request Mar 22, 2018
@NejcZdovc
Copy link
Contributor Author

master 777291b
0.23 cf77bfa
0.22 a8b26c3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When detecting a corrupted seed
2 participants