Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

After restoring wallet, redirect back to payments page #13647

Closed
wants to merge 1 commit into from
Closed

After restoring wallet, redirect back to payments page #13647

wants to merge 1 commit into from

Conversation

bsclifton
Copy link
Member

Fixes #13645

Unintentionally caused by #13621

Auditors: @NejcZdovc

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bsclifton bsclifton added this to the 0.22.x (Beta Channel) milestone Mar 29, 2018
@bsclifton bsclifton self-assigned this Mar 29, 2018
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same thing should happen if you close this dialog (press on X)

@codecov-io
Copy link

codecov-io commented Mar 29, 2018

Codecov Report

Merging #13647 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #13647      +/-   ##
==========================================
- Coverage   56.67%   56.63%   -0.05%     
==========================================
  Files         285      285              
  Lines       28881    28886       +5     
  Branches     4774     4774              
==========================================
- Hits        16369    16360       -9     
- Misses      12512    12526      +14
Flag Coverage Δ
#unittest 56.63% <0%> (-0.05%) ⬇️
Impacted Files Coverage Δ
...r/components/preferences/payment/ledgerRecovery.js 33.92% <0%> (-3.33%) ⬇️
js/stores/appStoreRenderer.js 91.66% <0%> (-8.34%) ⬇️
app/renderer/components/reduxComponent.js 57.75% <0%> (-3.45%) ⬇️
js/stores/windowStore.js 28.46% <0%> (-0.3%) ⬇️

@bsclifton
Copy link
Member Author

bsclifton commented Mar 29, 2018

I think the implementation should be a little better (ex: not rely on ledgerData) if we're to use it in more places. I'm going to close this for now

@bsclifton bsclifton closed this Mar 29, 2018
@bsclifton bsclifton deleted the fix-stuck-on-recovery branch March 29, 2018 07:05
@bsclifton bsclifton removed this from the 0.22.x (Beta Channel) milestone Mar 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants