This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fixes #12223: Mitigate HSTS Fingerprinting #13649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13649 +/- ##
==========================================
- Coverage 56.67% 56.64% -0.04%
==========================================
Files 285 285
Lines 28881 28907 +26
Branches 4774 4777 +3
==========================================
+ Hits 16369 16375 +6
- Misses 12512 12532 +20
|
diracdeltas
reviewed
Apr 2, 2018
| @@ -823,9 +823,15 @@ module.exports.runPreMigrations = (data) => { | |||
| } | |||
|
|
|||
| if (data.lastAppVersion) { | |||
| let runHSTSCleanup = false | |||
| try { runHSTSCleanup = compareVersions(data.lastAppVersion, '0.22.00') < 1 } catch (e) {} | |||
There was a problem hiding this comment.
this needs to be changed if this PR is going out in 0.23.x instead of 0.22.x
There was a problem hiding this comment.
update: since this is going out in 0.22.x release 2, this needs to be updated once we know the version number of 0.22.x release 1
There was a problem hiding this comment.
update: looks like the final version to compare against is 0.22.13
bsclifton
modified the milestones:
0.23.x (Developer Channel),
0.22.x Release 2 (Beta Channel)
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12223
Test Plan:
githubusercontentis loaded with a 301 redirectexample.comCached images and Filessafebrowsing-proxy.brave.comand verify that the ninja image is loaded with a 301 redirect.Cached images and Filesgithubusercontenthappens with a 307 redirect instead of 301.Alternative test plan if proxy site is not working
repeat steps above, but replace safebrowsing-proxy.com with https://jsfiddle.net/pqwdgr5x/5/