-
Notifications
You must be signed in to change notification settings - Fork 972
Conversation
Resolves brave#13227 Auditors: Test Plan:
Codecov Report
@@ Coverage Diff @@
## master #13867 +/- ##
==========================================
- Coverage 56.54% 56.51% -0.03%
==========================================
Files 283 283
Lines 28892 28895 +3
Branches 4788 4789 +1
==========================================
- Hits 16336 16330 -6
- Misses 12556 12565 +9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks sound, but I'm not able reproduce breaking my wallet to test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I too, am unable to break the wallet to reproduce and test.
However, could this PR introduce the possibility of triggering a wallet creation if one already exists? I'm concerned that without reproduction we only be able to confirm this is a visual fix. I'll keep trying to repro
@ryanml I don't see how this could trigger creating new wallet, because we just enable button. But yeah it's hard to be sure where we can't break the wallet 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code itself lgtm
This actually did happen to me about a month ago on my windows box where I already had wallet created, payments showed disabled, and clicking Enable Payments didn't do anything. No STR. Cleared out AppData parts and kept going. Didn't repeat after that. |
Fixes disabled create wallet button
Fixes disabled create wallet button
Resolves #13227
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Sadly I couldn't break the wallet to get to this state. I fixed this based on the logic that is there. I need help with test plan 😃
Reviewer Checklist:
Tests