Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Remove a not very useful focus ring on about pages (which is only sho… #13998

Merged
merged 1 commit into from
May 4, 2018
Merged

Remove a not very useful focus ring on about pages (which is only sho… #13998

merged 1 commit into from
May 4, 2018

Conversation

bsclifton
Copy link
Member

…wn around the entire body of preferences, not the individual controls)

Fixes #13992

Auditors: @petemill

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

…wn around the entire body of preferences, not the individual controls)

Fixes #13992

Auditors: @petemill
@bsclifton bsclifton added this to the 0.22.x Release 3 (Beta channel) milestone May 2, 2018
@bsclifton bsclifton self-assigned this May 2, 2018
@bsclifton bsclifton requested review from petemill and jasonrsadler May 2, 2018 23:08
@bsclifton
Copy link
Member Author

Focus ring was unintentionally introduced with 8597e72 (cc: @jasonrsadler)

The approach this PR takes is to hide the ring (versus removing the tabindex attribute, which may conflict with the changes @jasonrsadler made)

Copy link
Contributor

@jasonrsadler jasonrsadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm

@bsclifton bsclifton merged commit 4f84971 into brave:master May 4, 2018
@bsclifton bsclifton deleted the remove-about-focus-ring branch May 4, 2018 05:09
bsclifton added a commit that referenced this pull request May 4, 2018
Remove a not very useful focus ring on about pages (which is only sho…
bsclifton added a commit that referenced this pull request May 4, 2018
Remove a not very useful focus ring on about pages (which is only sho…
@bsclifton
Copy link
Member Author

master 4f84971
0.23.x 4685993
0.22.x-release3 3f3c154

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants