This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 975
Fixes extra visit time on first logged visit being ignored #13999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13999 +/- ##
==========================================
+ Coverage 56.44% 56.47% +0.02%
==========================================
Files 284 284
Lines 29353 29357 +4
Branches 4879 4879
==========================================
+ Hits 16568 16578 +10
+ Misses 12785 12779 -6
|
@ryanml this approach will not work because if you visit verified publisher you get enabled icon, but you don't get verified check, because we are only using local state and we don't trigger actual checks. I would suggest that we keep current logic and we just handle this time logging problem. |
Approach changed, RFR |
jasonrsadler
previously approved these changes
May 3, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good fix 🥇
@ryanml please add test for the reducer |
NejcZdovc
approved these changes
May 4, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ thx for the tests
NejcZdovc
added a commit
that referenced
this pull request
May 4, 2018
Fixes extra visit time on first logged visit being ignored
NejcZdovc
added a commit
that referenced
this pull request
May 4, 2018
Fixes extra visit time on first logged visit being ignored
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13993
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests