Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes broken seed overlay trigger #14002

Merged
merged 1 commit into from
May 3, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented May 3, 2018

Resolves #14001

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  1. Enable payments and close browser after wallet is created
  2. Edit ledger-state.json file and change the keyinfo section to look like this per When detecting a corrupted seed #13424 (comment):
    "keyinfo": {
    "seed": {
    "0": 0,
    "1": 0
    }
  3. Relaunch browser go to payments
  4. Make sure that broken seed overlay is shown

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Resolves brave#14001

Auditors:

Test Plan:
@NejcZdovc NejcZdovc added this to the 0.22.x Release 3 (Beta channel) milestone May 3, 2018
@NejcZdovc NejcZdovc self-assigned this May 3, 2018
@codecov-io
Copy link

Codecov Report

Merging #14002 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #14002      +/-   ##
==========================================
- Coverage   56.45%   56.42%   -0.03%     
==========================================
  Files         284      284              
  Lines       29361    29364       +3     
  Branches     4877     4877              
==========================================
- Hits        16576    16570       -6     
- Misses      12785    12794       +9
Flag Coverage Δ
#unittest 56.42% <100%> (-0.03%) ⬇️
Impacted Files Coverage Δ
app/browser/api/ledger.js 63.12% <100%> (+0.04%) ⬆️
js/stores/appStoreRenderer.js 91.66% <0%> (-8.34%) ⬇️
app/renderer/components/reduxComponent.js 57.75% <0%> (-3.45%) ⬇️
js/stores/windowStore.js 28.46% <0%> (-0.3%) ⬇️

Copy link
Contributor

@jasonrsadler jasonrsadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm

@jasonrsadler jasonrsadler merged commit 663cdc0 into brave:master May 3, 2018
jasonrsadler pushed a commit that referenced this pull request May 3, 2018
Fixes broken seed overlay trigger
jasonrsadler pushed a commit that referenced this pull request May 3, 2018
Fixes broken seed overlay trigger
@jasonrsadler
Copy link
Contributor

jasonrsadler commented May 3, 2018

master: 663cdc0
0.23: c176498
0.22.x-release3: da4118f

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken seed overlay is not displayed
3 participants