This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
When no frame index is provided for a new tab, insert at the end of the frame list #14102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he frame list Fix #14101 Whilst we do not display a tab until it has received tab-inserted-at and therefore has an index, we do switch the active Tab Page to the index of the new tab (if it is active), which would be the index of the tab page at tab index 0. A better fix would be to not add the frame to the window state until tab-inserted-at has been received. This could also help performance, especially if batched.
petemill
force-pushed
the
fix/14101-tab-page-change-new-tab
branch
from
883445a to
11854e6
Compare
ryanml
approved these changes
May 12, 2018
petemill
added a commit
that referenced
this pull request
May 12, 2018
When no frame index is provided for a new tab, insert at the end of the frame list
petemill
added a commit
that referenced
this pull request
May 12, 2018
When no frame index is provided for a new tab, insert at the end of the frame list
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14101
Whilst we do not display a tab until it has received tab-inserted-at and therefore has an index, we do switch the active Tab Page to the index of the new tab (if it is active), which would be the index of the tab page at tab index 0.
A better fix would be to not add the frame to the window state until tab-inserted-at has been received and we have the actual index, but that is a larger (high-risk) change that I'll contribute separately . This could also help performance, especially if batched.
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
On #14101
Reviewer Checklist:
Tests