Adds clear/delete payments options #14116

NejcZdovc · 2018-05-14T08:48:32Z

Resolves #8537

New options

Clear publishers option on shutdown

Manually clearing publishers and payment history

While contribution is in progress

Delete wallet

Delete wallet confirmation

Submitter Checklist:

Submitted a ticket for my issue if one did not already exist.
Used Github auto-closing keywords in the commit message.
Added/updated tests for this change (for new code or code which already has tests).
Ran git rebase -i to squash commits (if needed).
Tagged reviewers and labelled the pull request as needed.
Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

make sure that synopsis is not reset when only clear Browsing history is selected when reseting browser
make sure that ledger table is cleared, but not payment history when Brave Payments attention data is selected when restarting browser
make sure that ledger table is not cleared when contribution is in progress
make sure that ledger table is cleared when clearing data manually Brave Payments attention data
make sure that payment history is cleared when clearing data manually Brave Payments statements
make sure that payment options are disabled when contribution is in progress when you are clearing data manually

Reviewer Checklist:

Request a security/privacy review as needed if one was not already requested.

Tests

Adequate test coverage exists to prevent regressions
Tests should be independent and work correctly when run individually or as a suite ref
New files have MPL2 license header

bradleyrichter · 2018-05-15T00:27:01Z

@NejcZdovc please change "Usage data for Brave Payments" to:

"Brave Payments attention data" in both instances.

Change "Payment history" to:

"Brave Payments statements"

NejcZdovc · 2018-05-15T06:28:40Z

@bradleyrichter text updated, screenshots updated

jasonrsadler · 2018-05-28T21:55:25Z

app/browser/api/ledger.js

@@ -3123,6 +3126,53 @@ const activityRoundTrip = (err, response, body) => {
  updater.checkForUpdate(false, true)
 }

+const deleteWallet = (state) => {
+  state = ledgerState.deleteSynopsis(state)
+  state = state.setIn(['settings', settings.PAYMENTS_ENABLED], false)


I think we should make sure the file is deleted successfully before disabling payments.

I don't think that this is needed, because we will delete all data related to the payments in the state, so when you run it again it should override this file if still exists

jasonrsadler · 2018-05-28T22:01:10Z

app/renderer/components/main/clearBrowsingDataPanel.js

  }

  onToggleSetting (setting, e) {
    appActions.onToggleBrowsingData(setting, e.target.value)
  }

-  onClear () {
+  onClear (check) {
+    if (


Can we move this conditional to a separate function so it's clearer what's happening?

jasonrsadler · 2018-05-28T22:09:44Z

Can you add steps to test plan to be able to trigger contribution without hitting the 30 minute wall?

ryanml · 2018-05-28T22:10:32Z

app/browser/api/ledger.js

+const clearPaymentHistory = (state) => {
+  state = ledgerState.setInfoProp(state, 'transactions', Immutable.List())
+  state = ledgerState.setInfoProp(state, 'ballots', Immutable.List())
+  state = ledgerState.setInfoProp(state, 'batch', Immutable.List())


batch should be set to Immutable.Map() here, it is of type object in bat-client

ryanml · 2018-05-28T22:10:45Z

app/browser/api/ledger.js

+    if (data) {
+      data.transactions = []
+      data.ballots = []
+      data.batch = []


See above, should be data.batch = {}

ryanml · 2018-05-28T22:26:13Z

app/browser/api/ledger.js

+    fs.accessSync(path, fs.constants.W_OK)
+    let data = fs.readFileSync(path)
+    data = JSON.parse(data)
+    if (data) {


would it be helpful to set data.memos = [] in here?

We would like to keep memos, because we use them for debugging if needed

NejcZdovc · 2018-05-29T06:02:58Z

@jasonrsadler this is what I normally use when debugging contributions LEDGER_ENVIRONMENT=staging LEDGER_VERBOSE=true LEDGER_NO_FUZZING=true LEDGER_NO_DELAY=true npm run start

Resolves brave#8537 Auditors: Test Plan:

updated

ryanml

Works well, thanks for the updates 👍

Adds clear/delete payments options

NejcZdovc · 2018-05-29T16:24:12Z

master 141893c
0.23 65ad358
0.22 4463ecc

Adds clear/delete payments options

NejcZdovc added feature/rewards PR/work-in-progress ⚒ labels May 14, 2018

NejcZdovc self-assigned this May 14, 2018

NejcZdovc force-pushed the feature/#8537-clear branch 2 times, most recently from a780279 to 0a4c415 Compare May 14, 2018 08:53

NejcZdovc changed the title ~~Adds clear payments options~~ Adds clear/delete payments options May 14, 2018

NejcZdovc force-pushed the feature/#8537-clear branch from 0a4c415 to bb8c7af Compare May 14, 2018 11:24

NejcZdovc force-pushed the feature/#8537-clear branch 2 times, most recently from 7be8e2e to 2eae85d Compare May 15, 2018 07:49

NejcZdovc added this to the 0.22.x Release 5 milestone May 22, 2018

NejcZdovc force-pushed the feature/#8537-clear branch 6 times, most recently from a3a77d6 to 44bca51 Compare May 28, 2018 08:44

NejcZdovc requested review from bsclifton, jasonrsadler, kjozwiak and ryanml and removed request for bsclifton May 28, 2018 09:00

NejcZdovc added PR/pending-review and removed PR/work-in-progress ⚒ labels May 28, 2018

NejcZdovc force-pushed the feature/#8537-clear branch 3 times, most recently from 1a0c652 to 38a27a5 Compare May 28, 2018 13:20

jasonrsadler previously requested changes May 28, 2018

View reviewed changes

ryanml reviewed May 28, 2018

View reviewed changes

NejcZdovc force-pushed the feature/#8537-clear branch 3 times, most recently from 3a0c827 to e681429 Compare May 29, 2018 07:11

Adds clear payments options

45b7332

Resolves brave#8537 Auditors: Test Plan:

NejcZdovc force-pushed the feature/#8537-clear branch from e681429 to 45b7332 Compare May 29, 2018 07:14

NejcZdovc requested review from ryanml and jasonrsadler May 29, 2018 07:16

ryanml approved these changes May 29, 2018

View reviewed changes

NejcZdovc added a commit that referenced this pull request May 29, 2018

Merge pull request #14116 from NejcZdovc/feature/#8537-clear

65ad358

Adds clear/delete payments options

NejcZdovc added a commit that referenced this pull request May 29, 2018

Merge pull request #14116 from NejcZdovc/feature/#8537-clear

4463ecc

Adds clear/delete payments options

NejcZdovc closed this May 29, 2018

NejcZdovc removed the PR/pending-review label May 29, 2018

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this pull request May 29, 2018

Merge pull request brave#14116 from NejcZdovc/feature/brave#8537-clear

141893c

Adds clear/delete payments options

mrose17 mentioned this pull request May 29, 2018

Add "Clear Payment Data / Clear Payment history" option to about:preferences#security and delete wallet. #8537

Closed

LaurenWags mentioned this pull request Sep 19, 2018

add ability to reset Brave Rewards to pre-opt in state brave/brave-browser#1192

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds clear/delete payments options #14116

Adds clear/delete payments options #14116

NejcZdovc commented May 14, 2018 •

edited

Loading

bradleyrichter commented May 15, 2018 •

edited

Loading

NejcZdovc commented May 15, 2018

jasonrsadler May 28, 2018

NejcZdovc May 29, 2018

jasonrsadler May 28, 2018

jasonrsadler commented May 28, 2018

ryanml May 28, 2018 •

edited

Loading

NejcZdovc May 29, 2018

ryanml May 28, 2018

NejcZdovc May 29, 2018

ryanml May 28, 2018

NejcZdovc May 29, 2018

NejcZdovc commented May 29, 2018 •

edited by ryanml

Loading

ryanml left a comment

NejcZdovc commented May 29, 2018

Adds clear/delete payments options #14116

Adds clear/delete payments options #14116

Conversation

NejcZdovc commented May 14, 2018 • edited Loading

New options

Submitter Checklist:

Test Plan:

Reviewer Checklist:

bradleyrichter commented May 15, 2018 • edited Loading

NejcZdovc commented May 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jasonrsadler commented May 28, 2018

ryanml May 28, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NejcZdovc commented May 29, 2018 • edited by ryanml Loading

ryanml left a comment

Choose a reason for hiding this comment

NejcZdovc commented May 29, 2018

NejcZdovc commented May 14, 2018 •

edited

Loading

bradleyrichter commented May 15, 2018 •

edited

Loading

ryanml May 28, 2018 •

edited

Loading

NejcZdovc commented May 29, 2018 •

edited by ryanml

Loading