Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Only call createTabRequested if window is ready #14230

Merged
merged 1 commit into from
May 24, 2018
Merged

Only call createTabRequested if window is ready #14230

merged 1 commit into from
May 24, 2018

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented May 24, 2018

referralPage loads quickly from server and code was previously calling createTabRequested well before window was ready.
This would cause the partner page to load first (before about:welcome).

Fixes #14220

Auditors: @NejcZdovc

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

See #14220

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Referrer page loads quickly and code was previously calling createTabRequested well before window was ready.
This would cause the partner page to load first (before about:welcome).

Fixes #14220

Auditors: @NejcZdovc
@bsclifton bsclifton self-assigned this May 24, 2018
@bsclifton bsclifton requested a review from NejcZdovc May 24, 2018 05:30
@bsclifton bsclifton added this to the 0.22.x Release 4 (Beta channel) milestone May 24, 2018
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ looks good to me

@NejcZdovc NejcZdovc merged commit aa00fce into brave:master May 24, 2018
NejcZdovc added a commit that referenced this pull request May 24, 2018
Only call createTabRequested if window is ready
@bsclifton bsclifton deleted the fix-partner-page-focus branch May 24, 2018 07:03
NejcZdovc added a commit that referenced this pull request May 24, 2018
Only call createTabRequested if window is ready
@NejcZdovc
Copy link
Contributor

master aa00fce
0.23 7b0a0e2
0.22 655c06b

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants