Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Removes fixed input width #14312

Merged
merged 1 commit into from
Jun 1, 2018
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jun 1, 2018

Resolves #14309

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  • enable payments
  • select 100 BAT
  • make sure that input is width enough and that is adopting

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc self-assigned this Jun 1, 2018
@NejcZdovc NejcZdovc requested a review from ryanml June 1, 2018 21:20
Resolves brave#14309

Auditors:

Test Plan:
@NejcZdovc NejcZdovc force-pushed the fix/#14309-length branch from ee6b82b to 9cdd4c0 Compare June 1, 2018 21:21
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm

screen shot 2018-06-01 at 2 27 12 pm

@NejcZdovc NejcZdovc merged commit 848abfc into brave:master Jun 1, 2018
NejcZdovc added a commit that referenced this pull request Jun 1, 2018
NejcZdovc added a commit that referenced this pull request Jun 1, 2018
@NejcZdovc
Copy link
Contributor Author

master 848abfc
0.23 4f98aad
0.22 cfcffb1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants