Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Show tab loading icon when navigating from about:* content to http content #14384

Merged
merged 1 commit into from
Jun 12, 2018

Conversation

petemill
Copy link
Member

Fix #14207

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  • Unit tests

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@petemill petemill added this to the 0.23.x (Beta Channel) milestone Jun 12, 2018
@petemill petemill self-assigned this Jun 12, 2018
@petemill petemill changed the title Load tab loading icon when navigating from about:* content to http content Show tab loading icon when navigating from about:* content to http content Jun 12, 2018
@petemill petemill force-pushed the fix/14207-immediate-tab-loading-indicator branch from 28dad15 to 551aa7c Compare June 12, 2018 01:31
Copy link
Member

@diracdeltas diracdeltas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manually verified that this fixes #14207. lgtm

@diracdeltas diracdeltas changed the base branch from master to tor/0.23.x June 12, 2018 03:25
@diracdeltas diracdeltas changed the base branch from tor/0.23.x to master June 12, 2018 03:25
@diracdeltas diracdeltas merged commit 5d9c8b1 into master Jun 12, 2018
diracdeltas added a commit that referenced this pull request Jun 12, 2018
…indicator

Show tab loading icon when navigating from about:* content to http content
@diracdeltas
Copy link
Member

master: 5d9c8b1
0.23.x: 0b70d84

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants