Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Removes first level exclusion #14899

Merged
merged 2 commits into from
Aug 2, 2018
Merged

Removes first level exclusion #14899

merged 2 commits into from
Aug 2, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Aug 1, 2018 •
edited
Loading

Resolves #14890

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  • make sure that different publishers are added to the table (youtube, twitch, regular sites, amazon.com, etc)

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc
Restore cooked rules for ledger
ee75ce0 
Resolves #14890

Auditors:

Test Plan:
@NejcZdovc NejcZdovc added this to the 0.23.x Hotfix milestone Aug 1, 2018
@NejcZdovc NejcZdovc self-assigned this Aug 1, 2018
@ryanml ryanml mentioned this pull request Aug 2, 2018
Merged
@ryanml
Copy link
Contributor

ryanml commented Aug 2, 2018

Related bat-publisher update: brave-intl/bat-publisher#42

@ryanml ryanml self-requested a review August 2, 2018 17:21
@NejcZdovc NejcZdovc force-pushed the hotfix/#14890-rules branch from 03e2b95 to 0ef3d16 Compare August 2, 2018 18:14
@NejcZdovc NejcZdovc changed the title Restore cooked rules for ledger Removes first level exclusion Aug 2, 2018
@NejcZdovc
Copy link
Contributor Author

do not squash commits

@NejcZdovc NejcZdovc requested a review from bsclifton August 2, 2018 18:17
ryanml
ryanml approved these changes Aug 2, 2018
View reviewed changes
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@bsclifton bsclifton merged commit 7e68757 into master Aug 2, 2018
@bsclifton bsclifton deleted the hotfix/#14890-rules branch August 2, 2018 18:32
bsclifton added a commit that referenced this pull request Aug 2, 2018
@bsclifton
Merge pull request #14899 from brave/hotfix/#14890-rules
ff198de 
Removes first level exclusion
bsclifton added a commit that referenced this pull request Aug 2, 2018
@bsclifton
Merge pull request #14899 from brave/hotfix/#14890-rules
782a1ba 
Removes first level exclusion
bsclifton added a commit that referenced this pull request Aug 2, 2018
@bsclifton
Merge pull request #14899 from brave/hotfix/#14890-rules
f83a2c1 
Removes first level exclusion
@bsclifton
Copy link
Member

master 7e68757
0.24.x ff198de
0.23.x 782a1ba
0.23.x-hotfix1 f83a2c1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanml ryanml ryanml approved these changes

@bsclifton bsclifton Awaiting requested review from bsclifton

Assignees

@NejcZdovc NejcZdovc

Labels
None yet
Projects
None yet
Milestone
0.23.x Hotfix (Release Channel)
Development

Successfully merging this pull request may close these issues.
3 participants
@NejcZdovc @ryanml @bsclifton