This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Add content setting for media device access #14970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
reviewed
Aug 8, 2018
|
|
||
| if (chrome.contentSettings.mediaPermission == 'block') { | ||
| // Needed for https://github.com/brave/browser-laptop/issues/14889 | ||
| // Note this is not necessary in non-Electron-based codebases since Chromium |
There was a problem hiding this comment.
Can we also add chromium doesn't have mediaPermission in content setting? It is actually microphone && camera in chromium
|
also need to check |
fix #14889 Test plan: 1. go to https://www.webrtc-experiment.com/DetectRTC/ 2. confirm that (1) the results are the same as what chrome shows on that site and (2) you see a permission prompt for media access 3. click 'remember this decision' and 'allow' on the permission prompt and reload the page. 4. confirm that in the "System has Speakers?" and "System has Microphone?" section, it now shows descriptions of all your devices.
diracdeltas
force-pushed
the
fix/media-device-access
branch
from
dc9e04d to
4a79331
Compare
|
@darkdh addressed review comments and travis passes now |
darkdh
approved these changes
Aug 8, 2018
bsclifton
added a commit
that referenced
this pull request
Aug 8, 2018
Add content setting for media device access
bsclifton
added a commit
that referenced
this pull request
Aug 8, 2018
Add content setting for media device access
bsclifton
added a commit
that referenced
this pull request
Aug 8, 2018
Add content setting for media device access
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #14889
Test plan:
that site and (2) you see a permission prompt for media access
and reload the page.
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests