This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Context menu upgrades #1504
Merged
Context menu upgrades #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- menu on URL nearly matches spec (just missing "search with X") - menu for selection nearly matches spec (missing "look up X") - menu on page bg nearly matches spec (missing bravery menu) - menu for tab nearly matches spec (move to new window needs functionality)
|
Some screen caps: On link
On selection
On page BG
On tab
|
|
This looks good to me! Tested manually as well as code inspected.@bbondy or @diracdeltas would you like to confirm these changes as well? |
|
Thanks @bsclifton for the commit! |
|
You're welcome @aekeus! 😄 If you'd like, I can back out the incomplete items (since they were just implemented by putting a disabled menu item in place). The accompanying code has "//TODO:" blocks in the parts I didn't know about implementing Let me know and definitely curious what @bbondy and @diracdeltas think 😃 |
|
Thanks @bsclifton I'll merge this but ya please comment out the disabled items for now. Leaving it as is just commented for now is fine. Do that in a followup, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #1253
I need help working through the remaining items (search, bravery menu, move tab to new window)