Add font-awesome folder icon for folders on bookmarks toolbar and menus

[luixxiul]

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Ran git rebase -i to squash commits if needed.

Fix #1469

Image 1:

Please make sure that @bookmarksIconSize: 16px; is based on const iconSize = 16 (here).

I like the white icon better than fa-folder, which is a black icon.
http://fontawesome.io/icon/folder/

[bbondy]

The word bookmark shouldn't be in this file since it's a general context menu file.

[bbondy]

I suggest to modify js/contextMenu.js and look in bookmarkItemsInit. That's where icons are set. If you find it is a folder you can add a new property like faIcon and then if it is specified inside js/compnents/contextMenu.js you can use it.

[luixxiul]

OK I will

[luixxiul]

I'm trying to add bookmark icons in submenu, but can't :/

[bsclifton]

You were really close! Here's what I did that made it work:
https://github.com/bsclifton/browser-laptop/commit/98e06cfcfe6d08f43d6bcfab44fb07f5204517f6

Feel free to either make the commit yourself or add my remote and then cherry pick this hash (I can help if you don't know how to do that)

😄

[luixxiul]

Thanks! It was a great help :-)

[luixxiul]

OK I think it's ready.

[bsclifton]

lgtm! 👍

[luixxiul]

I think .bookmarkToolbar should be always 28px, in order to avoid this:

Should I send another PR to fix this?

[bsclifton]

Interesting.. what platform are you on? Here's how it looks for me (Windows).

Do the fonts get offset differently because you have unicode characters in the bookmarks toolbar?

[luixxiul]

It seems that the difference of padding settings causes it. If you set padding: 0px 10px in .bookmarksToolbar they are aligned well.

Either hiding the folder icon in the hide favicon mode or changing the folder icon size would also work.

Edit: this was fixed with 4c981f5, e142c53, and #1973.