This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Bookmark search + enhancements #2567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Searches existing bookmarks on character input * Cancelled when search text is cleared
* Added clear icon to search box when text is present * Cleared search box when folder selected * Sorted search results by title * Highlighted search results that are in the currently selected folder
Instead of choosing the first truthy of customTitle, title or location concatenate the values to form a single string to match against.
| // it as selected | ||
| if (this.props.inSelectedFolder) { | ||
| className += ' selected' | ||
| } |
There was a problem hiding this comment.
A better way to do this is with cx which allows you to selectively include or exclude css styles with a boolean expression. You can find some uses in the same file.
There was a problem hiding this comment.
Please do in a follow up as I'm going to merge this separately.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #995