Check hostname on basic auth #2623
Conversation
|
This can fix http://browserspy.dk/password.php |
|
For https://portal.adp.com/wps/employee/employee.jsp, maybe we should handle |
|
@diracdeltas pls review but seems good to me. |
| const frames = self.props.windowState.get('frames').filter((frame) => frame.get('location') === detail.url) | ||
| const frames = self.props.windowState.get('frames') | ||
| .filter((frame) => frame.get('location') === detail.url || | ||
| urlParse(frame.get('location')).hostname === urlParse(detail.url).hostname) |
There was a problem hiding this comment.
seems better to check by origin (scheme + hostname + port) instead of just hostname. see getOrigin in js/state/siteUtil.js.
There was a problem hiding this comment.
Thanks for your advice, @diracdeltas.
|
++ thanks |
git rebase -ito squash commits if needed.fix #1997