This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Tweak preview tabs timeout & transition. Fixes #142 #2780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the latest beta build I noticed #2062 started happenning again. |
|
Hi Suguru, yes, latest commits just smoothed transitions but actually didn't solve the problem. Hope this one will. |
|
the PR is labeled WIP, is it ready to merge or are you still working on it? |
|
@bbondy yep, it's working as is but I think animations can improve a bit so I'm digging it. |
|
@bradleyrichter please take a look on master and we'll go from there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP]
Notes on this commit:
I think that with this commit #1434 should be fixed without drawbacks and possibly #2641 / #2706 would need a new makeover.