Fix url in LOGIN_RESPONSE #2822

darkdh · 2016-07-30T09:36:11Z

Submitted a ticket for my issue if one did not already exist.
Used Github auto-closing keywords in the commit message.
Ran git rebase -i to squash commits if needed.

bbondy · 2016-07-31T01:37:47Z

js/components/loginRequired.js

@@ -69,7 +69,7 @@ class LoginRequired extends React.Component {
      username: '',
      password: ''
    })
-    ipc.send(messages.LOGIN_RESPONSE, this.props.frameProps.get('location'), this.state.username, this.state.password)
+    ipc.send(messages.LOGIN_RESPONSE, this.detail.url, this.state.username, this.state.password)


where is this.detail set?

nevermind I see the property, thanks.

Fix url in LOGIN_RESPONSE

0b376ed

fix brave#2807

darkdh added this to the 0.11.2dev milestone Jul 30, 2016

bbondy reviewed Jul 31, 2016
View reviewed changes

bbondy merged commit 41d4405 into brave:master Jul 31, 2016

darkdh deleted the 2807 branch August 4, 2016 15:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix url in LOGIN_RESPONSE #2822

Fix url in LOGIN_RESPONSE #2822

darkdh commented Jul 30, 2016 •

edited

Loading

bbondy Jul 31, 2016

bbondy Jul 31, 2016

Fix url in LOGIN_RESPONSE #2822

Fix url in LOGIN_RESPONSE #2822

Conversation

darkdh commented Jul 30, 2016 • edited Loading

bbondy Jul 31, 2016

Choose a reason for hiding this comment

bbondy Jul 31, 2016

Choose a reason for hiding this comment

darkdh commented Jul 30, 2016 •

edited

Loading