This repository was archived by the owner on Dec 11, 2019. It is now read-only.
Ledger monday updates #3318
Closed
Ledger monday updates #3318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and ensure that ledger-balance uses the built-in `roundtrip` function
| client = (require('ledger-client'))(null, underscore.extend({ roundtrip: roundtrip }, clientOptions), null) | ||
| } catch (ex) { | ||
| bootP = false | ||
| return console.log('ledger-client error: ' + ex.toString() + '\n' + ex.stack) |
There was a problem hiding this comment.
this now throws:
ledger-client error: Error: ENOENT: no such file or directory, open '/Users/yan/repos/browser-laptop/Brave-darwin-x64/Brave.app/Contents/Resources/app.asar.unpacked/node_modules/node-anonize2-relic-emscripten/anonize2.js.mem'
Error: ENOENT: no such file or directory, open '/Users/yan/repos/browser-laptop/Brave-darwin-x64/Brave.app/Contents/Resources/app.asar.unpacked/node_modules/node-anonize2-relic-emscripten/anonize2.js.mem'
at Error (native)
at Object.fs.openSync (fs.js:640:18)
at Object.module.(anonymous function) [as openSync] (ELECTRON_ASAR.js:167:20)
at Object.fs.readFileSync (fs.js:508:33)
at Object.fs.readFileSync (ELECTRON_ASAR.js:500:29)
at Object.read (/Users/yan/repos/browser-laptop/Brave-darwin-x64/Brave.app/Contents/Resources/app.asar/node_modules/node-anonize2-relic-emscripten/anonize2.js:18:1355)
at Object.readBinary (/Users/yan/repos/browser-laptop/Brave-darwin-x64/Brave.app/Contents/Resources/app.asar/node_modules/node-anonize2-relic-emscripten/anonize2.js:18:1623)
at Object.<anonymous> (/Users/yan/repos/browser-laptop/Brave-darwin-x64/Brave.app/Contents/Resources/app.asar/node_modules/node-anonize2-relic-emscripten/anonize2.js:33:3553)
at Module._compile (module.js:541:32)
at Object.Module._extensions..js (module.js:550:10)
There was a problem hiding this comment.
Brave-darwin-x64/Brave.app/Contents/Resources/app.asar.unpacked/node_modules/node-anonize2-relic-emscripten/ exists but is empty
| @@ -122,4 +122,8 @@ if (isLinux) { | |||
|
|
|||
| cmds.push('mkdirp ' + path.join(buildDir, 'resources', 'app.asar.unpacked', 'node_modules', 'spellchecker', 'vendor', 'hunspell_dictionaries')) | |||
| cmds.push('ncp ' + path.join('node_modules', 'spellchecker', 'vendor', 'hunspell_dictionaries') + ' ' + path.join(buildDir, 'resources', 'app.asar.unpacked', 'node_modules', 'spellchecker', 'vendor', 'hunspell_dictionaries')) | |||
|
|
|||
| cmds.push('mkdirp ' + path.join(buildDir, 'Brave.app', 'Contents', 'Resources', 'app.asar.unpacked', 'node_modules', 'node-anonize2-relic-emscripten')) | |||
| cmds.push('ncp ' + path.join('node_modules', 'node-anonize2-relic-emscripten', 'anonize2.js.mem') + ' ' + path.join(buildDir, 'Brave.app', 'Contents', 'Resources', 'app.asar.unpacked', 'node_modules', 'node-anonize2-relic-emscripten')) | |||
There was a problem hiding this comment.
error above appears to be fixed by changing this line to
cmds.push('ncp ' + path.join('node_modules', 'node-anonize2-relic-emscripten', 'anonize2.js.mem') + ' ' + path.join(buildDir, 'Brave.app', 'Contents', 'Resources', 'app.asar.unpacked', 'node_modules', 'node-anonize2-relic-emscripten', 'anonize2.js.mem'))
when starting without a client (in case, that information is cached in appState)
|
OBE by new branch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auditor: @diracdeltas
asarpackagingclientOptions.verbosePfor some calls toconsole.logupdatePublisherInfoat the correct places