Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

update ledger welcome page and partner logos #3381

Merged
merged 1 commit into from
Aug 27, 2016
Merged

Conversation

jkup
Copy link
Contributor

@jkup jkup commented Aug 24, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Ran git rebase -i to squash commits if needed.

Fix #3353

Tagging @bbondy @bradleyrichter

I guessed on a few of these font sizes, let me know if you'd like them different!

A few things I wanted to run by you all:

  • I would have rather used img tags for the logos, but I saw the only other place we have retina images we used this image-set approach. Should I do it this way? With empty divs?
  • I changed a lot in the translation files. Just wanted to make sure making those kind of changes isn't going to break anything for translations!

@bsclifton
Copy link
Member

Just checking it out now... the images aren't showing for me 😕
screen shot 2016-08-24 at 11 24 20 am

Console (cmd+option+i) has:

chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/gen/4bb98a05900622845d2e66b433711e32.png Failed to load resource: net::ERR_FILE_NOT_FOUND
chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/gen/1b0aa5afd818eff2fcc8b4386a8bc38b.png Failed to load resource: net::ERR_FILE_NOT_FOUND
chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/gen/3caa6d84e23f04adf06c13d4063cda48.png Failed to load resource: net::ERR_FILE_NOT_FOUND

@jkup jkup force-pushed the ledger-welcome-page branch from 70f8bfa to 9335d3a Compare August 25, 2016 03:48
@jkup
Copy link
Contributor Author

jkup commented Aug 25, 2016

@bsclifton :( that stinks. I have no idea. Do you see those images on your filesystem? They should be in: browser-laptop/app/extensions/brave/img/

@cezaraugusto
Copy link
Contributor

@jkup @bsclifton I faced the same issue while linking images on new tab page. Looks like there's a delay (likely from Electron?) that makes new files unavailable for a while. Crashing and then reopening the page did the trick here.

You can also try double-checking with npm run watch-all to see if the file was emitted.

@bbondy
Copy link
Member

bbondy commented Aug 25, 2016

@bsclifton pls review
@jkup this needs a rebase, thx.

git pull --rebase
git push -f

...will update the PR in place.

publisherPaymentsTitle=Brave Payments
publisherPaymentsTitleBeta=beta
paymentsSidebarText1=Our Partners
paymentsSidebarText2=All transactions are anonymized with technology from:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bradleyrichter seems like we should be more clear here. anonymize can mean a lot of things. all that we use PIA for is hiding real IP addresses. they do not anonymize payments, etc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is All transaction IP addresses are anonymized with technology from: too long?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fits. thanks.

@jkup jkup force-pushed the ledger-welcome-page branch from 9335d3a to df4808e Compare August 25, 2016 18:24
@bsclifton
Copy link
Member

bsclifton commented Aug 25, 2016

Weird- the images are still not showing for me. I used dev tools to disable cache and also tried crashing page, per suggestion of @cezaraugusto

EDIT:
Root cause for images not working was found; it was path related. Stopping webpack and starting it was what fixed it for me

@bsclifton
Copy link
Member

bsclifton commented Aug 25, 2016

Update- works great for me (and looks good, @jkup!) 😄 ++

I hadn't done an npm install in a while. Something during that process fixed it up

I also agree w/ @diracdeltas about the wording for the IP (although do we need to disable that temporarily?)

@jkup jkup force-pushed the ledger-welcome-page branch from df4808e to c07509e Compare August 26, 2016 02:26
@bradleyrichter
Copy link
Contributor

new URL for brave payments FAQ page:

https://brave.com/Payments_FAQ.html

@bsclifton bsclifton force-pushed the ledger-welcome-page branch from 86e1a46 to 147bf47 Compare August 26, 2016 22:16
@jkup jkup force-pushed the ledger-welcome-page branch from 147bf47 to 9f58599 Compare August 26, 2016 22:27
@jkup
Copy link
Contributor Author

jkup commented Aug 26, 2016

AFAIK this is good to go. Does it look good now @bradleyrichter @diracdeltas

@jkup jkup force-pushed the ledger-welcome-page branch from 9f58599 to 7fb5850 Compare August 26, 2016 23:13
@jkup jkup force-pushed the ledger-welcome-page branch from d852a9d to c6e1e6d Compare August 27, 2016 00:21
@jkup jkup mentioned this pull request Aug 27, 2016
3 tasks
@bbondy
Copy link
Member

bbondy commented Aug 27, 2016

@diracdeltas please review when you can, I'm going to merge in though for beta5.

@bbondy bbondy merged commit fc84905 into master Aug 27, 2016
@diracdeltas
Copy link
Member

are the logos supposed to go to the bottom like this when the window is narrow? if so, lgtm
screen shot 2016-08-27 at 12 16 45 am

@bradleyrichter
Copy link
Contributor

Ideally the text area should shrink to make room for the logos down to a min acceptable width. (400px?) Then everything stays.

If we don't have time for this, let's just have the logos stay put.

On Aug 27, 2016, at 12:18 AM, yan zhu (@bcrypt) notifications@github.com wrote:

are the logos supposed to go to the bottom like this when the window is narrow? if so, lgtm


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@luixxiul luixxiul added this to the 0.11.6dev milestone Aug 29, 2016
@bsclifton bsclifton deleted the ledger-welcome-page branch September 6, 2016 20:18
@incitadus
Copy link

I've been using Brave for about four days now and now receiving this error... brave won't
load....going to reinstall...... I really like this browser.

Your file was not found

It may have been moved or deleted.
ERR_FILE_NOT_FOUND

@bsclifton
Copy link
Member

@incitadus do you have more info? I'm trying to understand what the problem you're having is

When you open Brave, is that the error you're getting? Or is the error related to Brave Payments?

What operating system are you running? (Windows 10?). Please let me know and I can help 😄 👍

@incitadus
Copy link

incitadus commented Sep 17, 2017 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants