-
Notifications
You must be signed in to change notification settings - Fork 973
update ledger welcome page and partner logos #3381
Conversation
70f8bfa
to
9335d3a
Compare
@bsclifton :( that stinks. I have no idea. Do you see those images on your filesystem? They should be in: browser-laptop/app/extensions/brave/img/ |
@jkup @bsclifton I faced the same issue while linking images on new tab page. Looks like there's a delay (likely from Electron?) that makes new files unavailable for a while. Crashing and then reopening the page did the trick here. You can also try double-checking with |
@bsclifton pls review
...will update the PR in place. |
publisherPaymentsTitle=Brave Payments | ||
publisherPaymentsTitleBeta=beta | ||
paymentsSidebarText1=Our Partners | ||
paymentsSidebarText2=All transactions are anonymized with technology from: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bradleyrichter seems like we should be more clear here. anonymize
can mean a lot of things. all that we use PIA for is hiding real IP addresses. they do not anonymize payments, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is All transaction IP addresses are anonymized with technology from:
too long?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this fits. thanks.
9335d3a
to
df4808e
Compare
Weird- the images are still not showing for me. I used dev tools to disable cache and also tried crashing page, per suggestion of @cezaraugusto EDIT: |
Update- works great for me (and looks good, @jkup!) 😄 ++ I hadn't done an npm install in a while. Something during that process fixed it up I also agree w/ @diracdeltas about the wording for the IP (although do we need to disable that temporarily?) |
df4808e
to
c07509e
Compare
new URL for brave payments FAQ page: |
86e1a46
to
147bf47
Compare
147bf47
to
9f58599
Compare
AFAIK this is good to go. Does it look good now @bradleyrichter @diracdeltas |
9f58599
to
7fb5850
Compare
d852a9d
to
c6e1e6d
Compare
@diracdeltas please review when you can, I'm going to merge in though for beta5. |
Ideally the text area should shrink to make room for the logos down to a min acceptable width. (400px?) Then everything stays. If we don't have time for this, let's just have the logos stay put.
|
|
@incitadus do you have more info? I'm trying to understand what the problem you're having is When you open Brave, is that the error you're getting? Or is the error related to Brave Payments? What operating system are you running? (Windows 10?). Please let me know and I can help 😄 👍 |
That's the error I get when trying to open Brave. Using win10. Worked for
about a week
then the error started when I pinned to my start menu.Have deleted and
reinstalled several x's w/o
success. Thanks for your help.
…On Sat, Sep 16, 2017 at 6:40 PM, Brian Clifton ***@***.***> wrote:
@incitadus <https://github.com/incitadus> do you have more info? I'm
trying to understand what the problem you're having is
When you open Brave, is that the error you're getting? Or is the error
related to Brave Payments?
What operating system are you running? (Windows 10?). Please let me know
and I can help 😄 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3381 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Aegv3MoxpSqgwRgoC0MoG1EhNQB3-3HEks5sjE5KgaJpZM4JsSXl>
.
|
git rebase -i
to squash commits if needed.Fix #3353
Tagging @bbondy @bradleyrichter
I guessed on a few of these font sizes, let me know if you'd like them different!
A few things I wanted to run by you all: