This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
History bugfixes #3459
Merged
History bugfixes #3459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (reduced) { | ||
| return Array.isArray(reduced) | ||
| ? reduced | ||
| : [{date: this.getDayString(locale, reduced), entries: [reduced]}] |
There was a problem hiding this comment.
This line has the fix for showing single entries. Before, it would just return the object (which fails when trying to do the map() in the render for the HistoryDay control)
This was referenced Aug 26, 2016
| @@ -414,6 +414,50 @@ describe('siteUtil', function () { | |||
| }) | |||
| }) | |||
|
|
|||
| describe('isHistoryEntry', function () { | |||
| it('returns true for a typical history entry', function () { | |||
There was a problem hiding this comment.
not sure if someone else reading this will understand what makes it "typical". Maybe "returns true for site entries with a lastAccessedTime"?
|
Looks good! I think ideally we'd like to filter the data before it gets to the history page, but we can do a larger refactoring later |
This was referenced Aug 27, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits if needed.