This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Update getActivePasswordManager call to call getSettings #3536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @bbondy |
Please post one and update PR. Thanks. |
|
Issue created which has comprehensive STR 😄 (tagged as qa-steps-specified for verification). I have manually verified the fix on Mac. Ready for review! |
To verify the fix
|
|
++ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't find an existing issue for thisThis change only affects the context menu after upgrading from 0.11.4 or earlier to 0.11.5 or newer. Currently, the context menu is the only caller for getActivePasswordManager
Fixes #3549
Auditors: @bbondy @alexwykoff